Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for using OpenAI subscriptions #4

Closed
wants to merge 1 commit into from

Conversation

hootanht
Copy link

@hootanht hootanht commented Sep 2, 2024

Fixes #2

Add support for configuring OpenAI subscriptions directly.

  • README.md:
    • Add instructions for configuring OpenAI subscriptions.
    • Update example code to include OpenAI configuration.
  • src/skUnit/Asserts/SemanticAssert.cs:
    • Add a new constructor to accept OpenAI API key directly.
  • src/skUnit/Asserts/SemanticKernelAssert_Initialize.cs:
    • Add a new constructor to accept OpenAI API key directly.
  • src/skUnit.Tests/SemanticAssertTests/SemanticAssertTests.cs:
    • Add tests for the new OpenAI constructor.
    • Update existing tests to include OpenAI configuration.

Fixes mehrandvd#2

Add support for configuring OpenAI subscriptions directly.

* **README.md**:
  - Add instructions for configuring OpenAI subscriptions.
  - Update example code to include OpenAI configuration.
* **src/skUnit/Asserts/SemanticAssert.cs**:
  - Add a new constructor to accept OpenAI API key directly.
* **src/skUnit/Asserts/SemanticKernelAssert_Initialize.cs**:
  - Add a new constructor to accept OpenAI API key directly.
* **src/skUnit.Tests/SemanticAssertTests/SemanticAssertTests.cs**:
  - Add tests for the new OpenAI constructor.
  - Update existing tests to include OpenAI configuration.
@mehrandvd
Copy link
Owner

@hootanht wow... thank you for contributing :)

@mehrandvd
Copy link
Owner

mehrandvd commented Jan 20, 2025

The latest changes already add support for OpenAI subscription and support for IChatClient.
Now you can pass an IChatClient which can be instantiated using any provider.

So, I'm closing this PR.

@mehrandvd mehrandvd closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better support for using OpenAI subscriptions.
2 participants