Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fork tracking] Chinese Segmenter enhancements #253

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ManyTheFish
Copy link
Member

This PR is not meant to be merged.
This PR is here to easily follow the enhancement made on https://github.com/lzw65/charabia

@ManyTheFish ManyTheFish changed the title [Fork tracking]: Chinese Segmenter enhancements [Fork tracking] Chinese Segmenter enhancements Jan 9, 2024
@Kimeiga
Copy link

Kimeiga commented Jan 11, 2024

hi I looked through zhiwu's code and the use of a traditional to simplified normalizer is very smart; I was just wondering if there's a timeline for when this work will get merged? Thanks for your work!

@lzw65 lzw65 force-pushed the main branch 3 times, most recently from 899655d to fa5a268 Compare January 16, 2024 02:00
Fix lindera UniDic download error

Support traditional_to_simplified

update curstom dict
@ManyTheFish
Copy link
Member Author

Hello @Kimeiga,
I don't know if the traditional to simplified normalizer is relevant because the kvariant table already makes the relation between these two. Moreover, character_converter has some performance issues and is not maintained by a native Chinese speaker. I'm wondering but for me, the real enhancement is to handle pinyin differently and be able to generate Chinese specialized ngrams. 🤔
The issue is that is not an easy problem to tackle. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants