-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor key types #1917
base: main
Are you sure you want to change the base?
Refactor key types #1917
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 99.02% 99.02% -0.01%
==========================================
Files 18 18
Lines 1435 1433 -2
Branches 303 301 -2
==========================================
- Hits 1421 1419 -2
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Pull Request
What does this PR do?
Caution
Breaking changes
Date
types are nowstring
types, conversion has to be done manuallyKeysQuery
->ListApiKeys
KeysResults
->KeyViewList
Key
->KeyView
KeyCreation
->CreateApiKey
KeyUpdate
->PatchApiKey
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!