forked from h5p/h5p-php-library
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.2 fixing & cleanup #1
Open
liayn
wants to merge
30
commits into
meirzamoodle:master
Choose a base branch
from
liayn:dynamic_properties
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b4b1df3.
This reverts commit 079191e.
* JI-5135 fix confirmation dialog double screen read * JI-5135 read popup header once * JI-5135 remove unused id
* JI-5135 revert changes * JI-5135 tweak comment
This is a continuation of the work to avoid dynamic property depreciation warnings in PHP 8.2
…Countable|array, string given (h5p#121) * fix: Fixed PHP8 compatibility TypeError: count(): Argument meirzamoodle#1 ($value) must be of type Countable|array, string given * fix: Fixed (TypeError) PHP8 compatibility TypeError: count(): Argument meirzamoodle#1 ($value) must be of type Countable|array, string given
JI-5682 add cropper translations
…5p#177) Co-authored-by: William Almnes <[email protected]>
* HFP-3875 Add icons for expand and collapse * HFP-3875 Use font file provided by UX * HFP-3875 Clean up font assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.