C2C-305: Add openmrs, bahmni and odoo configs locally and fix pom.xml

[VaishSiddharth]

JIRA: https://mekomsolutions.atlassian.net/browse/C2C-305

[Ruhanga]

Thanks for the PR @VaishSiddharth. I have one comment to address: I suggest organizing the relevant folder structure like this:

configs/
├── bahmni/
│   ├── frontend/
│   │   └── openmrs/
│   └── .../
├── odoo/
│   └── initializer_config/
│   └── .../
└── openmrs/
    └── initializer_config/
    └── .../

[rbuisson]

@Ruhanga , for now, let's keep the same structure as it was before. The task is only to move the configs "as is" into the distros.

[rbuisson]

@VaishSiddharth , let me correct myself, let's rework the structure to be as per @Ruhanga 's comment. (I didn't know it was already done for TLC)

configs/
|-- openmrs/
|-- odoo/
|-- bahmni/

[rbuisson]

@VaishSiddharth did you verify the contents of the final package to make sure they're identical with the latest distro package?
If not, this command will help: diff -qr /path/to/folder1 /path/to/folder2

[VaishSiddharth]

@rbuisson @Ruhanga have fixed the structure and tested master and this branch build (target) folders with diff -qr command
Only difference is in SNAPSHOT.zip folders that must be because the command cannot find whats inside the zip folder.
Also the folder naming is a bit different

configs/
|-- openmrs_config/
|-- odoo_config/
|-- bahmni_config/
|-- analytics_config/

[Ruhanga]

configs/
|-- openmrs_config/
|-- odoo_config/
|-- bahmni_config/
|-- analytics_config/

I don't think the trailing _config is necessary especially if the parent folder is already named configs. Something like below would be more consistent with what we've done already implemented as shared in the previous comments.

configs/
|-- openmrs/
|-- odoo/
|-- bahmni/
|-- analytics/

[VaishSiddharth]

Agreed @Ruhanga. Fixed the folder names. Thanks for pointing out that it is redundant

[Ruhanga]

Overall, it looks great. I have just two comments below:

[Ruhanga]

There can be additional types of configurations for OpenMRS, so it would be reasonable to allow for this, such as:
directory>${project.basedir}/configs/openmrs/initializer</directory>

[VaishSiddharth]

Done for odoo and openmrs configs.

[Ruhanga]

There can be additional types of configurations for Odoo, so it would be reasonable to allow for this, such as:
directory>${project.basedir}/configs/odoo/initializer</directory>

[VaishSiddharth]

Done for odoo and openmrs configs.

[rbuisson]

@Ruhanga @VaishSiddharth are you saying we also rename the final package folders to:

configs/
|-- openmrs/
|-- odoo/
|-- bahmni/
|-- analytics/

Because if so, then this will quite have an impact on deployment (as for mounting the volumes).

[VaishSiddharth]

No the build is identical apart from these files/folder

Files new/target/bahmni-distro-c2c-1.7.0-SNAPSHOT.zip and old/target/bahmni-distro-c2c-1.7.0-SNAPSHOT.zip differ
Only in old/target/dependency-maven-plugin-markers: net.mekomsolutions-bahmni-config-c2c-zip-1.4.0-SNAPSHOT.marker
Only in old/target/dependency-maven-plugin-markers: net.mekomsolutions-odoo-config-c2c-zip-1.7.0-SNAPSHOT.marker
Only in old/target/dependency-maven-plugin-markers: net.mekomsolutions-openmrs-config-c2c-zip-1.7.0-SNAPSHOT.marker

[rbuisson]

@Ruhanga , did you try to run the distro on this PR?

[Ruhanga]

@rbuisson no, I'll give it a try and comment. There were a few things that have now been addressed.

[Ruhanga]

Generally looks good. Building this fails with the error below + one minor concern to address below

main:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.877 s
[INFO] Finished at: 2024-10-15T14:15:07+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7:run (rename-openmrs-config) on project bahmni-distro-c2c: An Ant BuildException has occured: ~/bahmni-distro-c2c/target/bahmni-distro-c2c-1.7.0-SNAPSHOT/openmrs_config does not exist.
[ERROR] around Ant part ...<move todir="~/bahmni-distro-c2c/target/bahmni-distro-c2c-1.7.0-SNAPSHOT/openmrs_config">... @ 4:128 in ~/bahmni-distro-c2c/target/antrun/build-main.xml
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

[Ruhanga]

LGTM