Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA-427: Update the existing ENVs check to avoid matching unwanted ENVs #44

Merged
merged 1 commit into from
Jan 31, 2024
Merged

INFRA-427: Update the existing ENVs check to avoid matching unwanted ENVs #44

merged 1 commit into from
Jan 31, 2024

Conversation

enyachoke
Copy link
Collaborator

No description provided.

rbuisson
rbuisson approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@rbuisson rbuisson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enyachoke there is no proper testing of the grep behavior, right? Tests only verify that the right commands are spit out.

@enyachoke
Copy link
Collaborator Author

@enyachoke there is no proper testing of the grep behavior, right? Test only verify that the right commands are spit out.

That is correct

@enyachoke enyachoke merged commit 1cf84cf into mekomsolutions:master Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuisson rbuisson rbuisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enyachoke @rbuisson