KH-520: Fix failing builds on PR from forked repositories #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliouzbett
force-pushed
the
ci-fork
branch
5 times, most recently
from
bdbf832 to
0d5e619
Compare
rbuisson
reviewed
Jul 2, 2024
rbuisson
reviewed
Jul 2, 2024
| uses: mekomsolutions/shared-github-workflow/.github/workflows/maven-build-test.yml@main | ||
| with: | ||
| java-version: "8" | ||
| maven-phase: "install" | ||
| maven-args: "-P prod" # Remove -Pvalidator to temporarily bypass validation |
There was a problem hiding this comment.
Could you still keep the comment which indicates that the validation is disabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of failing builds on pull requests from forked repositories. Fork repos don't have access to secrets for security reasons.
The change here ensures that
basemodule is validated on PR and both on push to main sinceprodmodule requires access to secrets.