add '-n' switch to sudo command

[khurlbut]

No description provided.

[melezhik]

Hi @khurlbut , I would rather add this as configurable option, so that keep back compatibility, we can add non-interactive checkbox in advanced settings, which is true by default , to configure sudo -n , what do you think?

[khurlbut]

I agree. 'sudo -n' true by default but configurable. Checkbox sounds good to me. K  From: Alexey Melezhik <[email protected]> To: melezhik/chef-plugin <[email protected]> Cc: khurlbut <[email protected]>; Mention <[email protected]> Sent: Monday, October 29, 2018 6:57 AM Subject: Re: [melezhik/chef-plugin] add '-n' switch to sudo command (#12) Hi @khurlbut , I would rather add this as configurable option, so that keep back compatibility, we can add non-interactivecheckbox in advanced settings, which is true by default , to configuresudo -n` , what do you think?— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[melezhik]

@khurlbut cool, would you be able to add corresponding controls to view and adjust controller logic?

[khurlbut]

i'll take a look. From: Alexey Melezhik <[email protected]> To: melezhik/chef-plugin <[email protected]> Cc: khurlbut <[email protected]>; Mention <[email protected]> Sent: Monday, October 29, 2018 10:08 AM Subject: Re: [melezhik/chef-plugin] add '-n' switch to sudo command (#12) @khurlbut cool, would you be able to add corresponding controls to view and adjust controller logic?— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[khurlbut]

OK. I've added a checkbox to control the -n switch.

[melezhik]

Cool. Thanks.

Could you also please clarify this commit?

5dc01a1

Not sure, if I understand ...

[melezhik]

"the way the plugin is now, there isn't a problem, except that -c /etc/chef/client.rb is the default anyway so it's redundant. if he were to easily allow -c /path/to/anywhere.rb it opens you up to getting a root shell. but my real complaint was just: why bother to add that -c suffix when it's needless?"

the line config_path = " -c #{@chef_client_config}" unless (@chef_client_config.nil? || @chef_client_config.empty?) is important. People can override the path to chef configuration file through plugin settings. If people do not choose custom path to configuration file, chef-client runs without -c options which makes it use default configuration file.

[khurlbut]

I see your point, Alexey. I've uncommented the line in question. This PR now only includes changes in support of the '-n' switch.

[melezhik]

Yeah. I am ok with current PR. Have you managed to test the plugin through jpi? It's been a while since I touched the plugin development last time, looks like things has changed and my jpi test jenkins fails to create jobs, there are errors in the Jenkins log. Which jruby version do you use? Without that I cannot even release a plugin ... ):

I wonder if jpi is maintained at all, last release is more than 2 years ago. I am going to create cross issue on their side with all the details.

[melezhik]

jenkinsci/jenkins.rb#124