Bind 'Toggle Fullscreen' hotkey to F11 by default #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the default settings to bind the hotkey which toggles fullscreen to the F11 key.
I am proposing this due to my personal initial impression with the emulator, where I experienced immediate confusion on how I was supposed to full-screen the emulator. At first I tried pressing F11, as is convention with all software, and nothing happened. I then attempted to find a fullscreen toggle in various corners of the menu bar, to no effect.
This led to me having to use the internet to find out how to enter fullscreen, which lead to me finding a year old Reddit thread explaining that a hotkey existed and that many people were unnecessarily using command line parameters without knowing this information.
This seems like quite poor UX, so I believe that MelonDS should follow expected software convention and use the F11 key to enter fullscreen by default, as this is the behaviour that most users will assume.
I am unfamiliar with this codebase, so please correct me if I have approached implementing this incorrectly.