Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tap tests for multiple test classes with different input catalogs #1913

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 16, 2023

@edgarrmondragon edgarrmondragon linked an issue Aug 16, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1913 (40c6a0d) into main (c9eda5a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
+ Coverage   86.94%   86.95%   +0.01%     
==========================================
  Files          59       59              
  Lines        5080     5084       +4     
  Branches      822      823       +1     
==========================================
+ Hits         4417     4421       +4     
  Misses        466      466              
  Partials      197      197              
Files Changed Coverage Δ
singer_sdk/testing/factory.py 93.80% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 17, 2023 02:24
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) August 17, 2023 02:32
@edgarrmondragon edgarrmondragon merged commit 2e45606 into main Aug 17, 2023
25 checks passed
@edgarrmondragon edgarrmondragon deleted the 1912-bug-tap-tests-parameters-are-cached-across-test-classes branch August 17, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Tap tests parameters are cached across test classes
1 participant