refactor: Improved SQL identifier (de)normalization #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2601 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2601 +/- ##
==========================================
+ Coverage 89.50% 89.57% +0.06%
==========================================
Files 58 58
Lines 4804 4816 +12
Branches 943 943
==========================================
+ Hits 4300 4314 +14
+ Misses 351 350 -1
+ Partials 153 152 -1 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/handle-sql-ident-normalization
branch
from
3161fdf
to
46c9e1a
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/handle-sql-ident-normalization
branch
from
46c9e1a
to
e0ed470
Compare
edgarrmondragon
deleted the
edgarrmondragon/refactor/handle-sql-ident-normalization
branch
edgarrmondragon
added a commit
to MeltanoLabs/target-snowflake
that referenced
this pull request
Aug 13, 2024
Related: - Blocked by meltano/sdk#2601 - Closes #230 --------- Co-authored-by: Pat Nadolny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
SQL compilation error...unexpected '.'when table name isORDERMeltanoLabs/target-snowflake#230📚 Documentation preview 📚: https://meltano-sdk--2601.org.readthedocs.build/en/2601/