Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use future warnings.deprecated decorator #2647

Merged

Conversation

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2647 will not alter performance

Comparing edgarrmondragon/refactor/future-deprecated-decorator (7a6be32) with main (93a0796)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.61%. Comparing base (93a0796) to head (7a6be32).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
singer_sdk/authenticators.py 60.00% 1 Missing and 1 partial ⚠️
singer_sdk/connectors/sql.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
- Coverage   89.67%   89.61%   -0.07%     
==========================================
  Files          58       58              
  Lines        4854     4861       +7     
  Branches      950      955       +5     
==========================================
+ Hits         4353     4356       +3     
- Misses        350      352       +2     
- Partials      151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 6, 2024 16:12
@edgarrmondragon edgarrmondragon merged commit e46a1cd into main Sep 6, 2024
37 of 38 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/future-deprecated-decorator branch September 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant