Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove non-functional record-flattening capability #2666

Merged
merged 3 commits into from
Sep 12, 2024
Merged

refactor: Remove non-functional record-flattening capability #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6765ccb
Document missing `schema-flattening` base capability
ReubenFrankel Sep 12, 2024
d9d00cd
Remove unused `record-flattening` capability
ReubenFrankel Sep 12, 2024
899e41f
Merge branch 'main' into chore/record-flattening-unused
ReubenFrankel Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cookiecutter/target-template/{{cookiecutter.target_id}}/meltano.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins:
capabilities:
- about
- stream-maps
- record-flattening
- schema-flattening

# TODO: Declare settings and their types here:
settings:
Expand Down
2 changes: 1 addition & 1 deletion docs/capabilities.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The following capabilities are supported by default.
.. autoattribute:: PluginCapabilities.ABOUT
.. autoattribute:: PluginCapabilities.BATCH
.. autoattribute:: PluginCapabilities.STREAM_MAPS
.. autoattribute:: PluginCapabilities.FLATTENING

========================
Custom base capabilities
Expand Down Expand Up @@ -60,5 +61,4 @@ The following capabilities have to be implemented in the target.
.. autoattribute:: TargetCapabilities.SOFT_DELETE
.. autoattribute:: TargetCapabilities.HARD_DELETE
.. autoattribute:: TargetCapabilities.DATATYPE_FAILSAFE
.. autoattribute:: TargetCapabilities.RECORD_FLATTENING
.. autoattribute:: TargetCapabilities.TARGET_SCHEMA
3 changes: 0 additions & 3 deletions singer_sdk/helpers/capabilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,6 @@ class TargetCapabilities(CapabilitiesEnum):
#: Fail safe for unknown JSON Schema types.
DATATYPE_FAILSAFE = "datatype-failsafe"

#: Allow denesting complex properties.
RECORD_FLATTENING = "record-flattening"

#: Allow setting the target schema.
TARGET_SCHEMA = "target-schema"

Expand Down
Loading