Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Targets now emit record count from the built-in batch file processor #2703

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 4, 2024

Closes #2702


📚 Documentation preview 📚: https://meltano-sdk--2703.org.readthedocs.build/en/2703/

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/records-batch-metric branch from 3167340 to 8d8e032 Compare October 4, 2024 02:16
Copy link

codspeed-hq bot commented Oct 4, 2024

CodSpeed Performance Report

Merging #2703 will not alter performance

Comparing edgarrmondragon/feat/records-batch-metric (59a8d34) with main (8c7c307)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (8c7c307) to head (59a8d34).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2703   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files          62       62           
  Lines        5143     5145    +2     
  Branches      662      662           
=======================================
+ Hits         4672     4674    +2     
  Misses        330      330           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.43.0 milestone Oct 18, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 15, 2024
@edgarrmondragon edgarrmondragon added kind/Feature New feature or request Type/Target Singer targets BATCH Support for BATCH messages labels Nov 15, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 26, 2024 23:02
@edgarrmondragon edgarrmondragon merged commit 39f7325 into main Nov 26, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/records-batch-metric branch November 26, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BATCH Support for BATCH messages kind/Feature New feature or request Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Emit record count from the built-in batch file processor in targets
1 participant