-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapping from JSON schema to SQL column type
edgarrmondragon
changed the title
feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type
feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type
Oct 25, 2024
edgarrmondragon
added
Needs Documentation
Release Highlight
Call this out in the release notes
labels
Oct 25, 2024
CodSpeed Performance ReportMerging #2732 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
==========================================
+ Coverage 90.71% 90.80% +0.08%
==========================================
Files 62 62
Lines 5021 5089 +68
Branches 641 658 +17
==========================================
+ Hits 4555 4621 +66
- Misses 324 326 +2
Partials 142 142 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/feat/jsonschema-to-sql
branch
from
October 30, 2024 21:04
ade09a2
to
28bc9c7
Compare
edgarrmondragon
added a commit
to MeltanoLabs/target-postgres
that referenced
this pull request
Nov 7, 2024
…es to SQL data types (#469) Related: - meltano/sdk#2732
edgarrmondragon
added a commit
that referenced
this pull request
Nov 11, 2024
… mapping from JSON schema to SQL column type (#2732) * feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type * Add failing test for complex type case * Correctly handle multiple types * Make mypy happy * Test more cases * Add docs * Fix annotation in docs * Support custom fallbacks * Add a way to customize raw string handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Related:
SQLConnector.jsonschema_to_sql
to map JSON schema types to SQL data types MeltanoLabs/target-postgres#469📚 Documentation preview 📚: https://meltano-sdk--2732.org.readthedocs.build/en/2732/