Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type #2732

Merged
merged 14 commits into from
Nov 6, 2024

Conversation

@edgarrmondragon edgarrmondragon changed the title feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type feat(targets): SQL target developers can now more easily override the mapping from JSON schema to SQL column type Oct 25, 2024
@edgarrmondragon edgarrmondragon added Needs Documentation Release Highlight Call this out in the release notes labels Oct 25, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 25, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 25, 2024
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #2732 will not alter performance

Comparing edgarrmondragon/feat/jsonschema-to-sql (dea21ae) with main (2ad977e)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (2ad977e) to head (dea21ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
+ Coverage   90.71%   90.80%   +0.08%     
==========================================
  Files          62       62              
  Lines        5021     5089      +68     
  Branches      641      658      +17     
==========================================
+ Hits         4555     4621      +66     
- Misses        324      326       +2     
  Partials      142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit de7d1dc into main Nov 6, 2024
38 of 39 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/jsonschema-to-sql branch November 6, 2024 23:05
edgarrmondragon added a commit to MeltanoLabs/target-postgres that referenced this pull request Nov 7, 2024
edgarrmondragon added a commit that referenced this pull request Nov 11, 2024
… mapping from JSON schema to SQL column type (#2732)

* feat(target): SQL target developers can now more easily override the mapping from JSON schema to SQL column type

* Add failing test for complex type case

* Correctly handle multiple types

* Make mypy happy

* Test more cases

* Add docs

* Fix annotation in docs

* Support custom fallbacks

* Add a way to customize raw string handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation Release Highlight Call this out in the release notes
Projects
Status: Discussed
Development

Successfully merging this pull request may close these issues.

1 participant