-
Notifications
You must be signed in to change notification settings - Fork 83
Implement option to disable cache rebuild if it already exists in storage #102
Conversation
90cf7c1
to
67fcde3
Compare
I don't think test failure is related to this PR |
67fcde3
to
343715d
Compare
Ok, might be just tests are not stable, after force push now they succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Thanks a lot for your contribution. I believe this could improve the user experience a lot. We can consider having this check by default for upcoming releases.
I have a couple of nits, it'd be awesome if you can handle those.
Also, we have a checklist https://github.com/meltwater/drone-cache/blob/master/CONTRIBUTING.md#pull-request-checklist, it'd glad if you have a look at it.
Since we add a new option we should update the CHANGELOG, I'd also forgotten to update it, just did. So rebase before you make a change on it.
33503a5
to
89e27aa
Compare
…rage Signed-off-by: Lauris BH <[email protected]>
89e27aa
to
172764a
Compare
@kakkoyun done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This will be in the next stable release |
Could you restart drone master build task? :) |
CI is killing me 😓 |
Description
Adds
override
option that is true by default to preserve backward compatibilityFixes #83
Checklist
Unreleased
section of CHANGELOG.