Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Implement option to disable cache rebuild if it already exists in storage #102

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Apr 7, 2020

Description

Adds override option that is true by default to preserve backward compatibility

Fixes #83

Checklist

  • Read the CONTRIBUTING document. (It's checked since you are already here.)
  • Read the CODE OF CONDUCT document.
  • Add tests to cover changes.
  • Ensure your code follows the code style of this project.
  • Ensure CI and all other PR checks are green OR
    • Code compiles correctly.
    • Created tests which fail without the change (if possible).
    • All new and existing tests passed.
  • Add your changes to Unreleased section of CHANGELOG.
  • Improve and update the README (if necessary).
  • Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

@lafriks lafriks force-pushed the feat/rebuild_override branch 2 times, most recently from 90cf7c1 to 67fcde3 Compare April 7, 2020 19:27
@lafriks
Copy link
Contributor Author

lafriks commented Apr 7, 2020

I don't think test failure is related to this PR

@lafriks lafriks force-pushed the feat/rebuild_override branch from 67fcde3 to 343715d Compare April 7, 2020 21:20
@lafriks
Copy link
Contributor Author

lafriks commented Apr 7, 2020

Ok, might be just tests are not stable, after force push now they succeeded

@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 8, 2020

@lafriks CI failures are unrelated, I've opened an issue about it #104.

Checking the rest of the PR now.

Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Thanks a lot for your contribution. I believe this could improve the user experience a lot. We can consider having this check by default for upcoming releases.

I have a couple of nits, it'd be awesome if you can handle those.
Also, we have a checklist https://github.com/meltwater/drone-cache/blob/master/CONTRIBUTING.md#pull-request-checklist, it'd glad if you have a look at it.

Since we add a new option we should update the CHANGELOG, I'd also forgotten to update it, just did. So rebase before you make a change on it.

@lafriks lafriks force-pushed the feat/rebuild_override branch 2 times, most recently from 33503a5 to 89e27aa Compare April 8, 2020 08:18
@lafriks lafriks force-pushed the feat/rebuild_override branch from 89e27aa to 172764a Compare April 8, 2020 08:23
@lafriks
Copy link
Contributor Author

lafriks commented Apr 8, 2020

@kakkoyun done

@lafriks lafriks requested a review from kakkoyun April 8, 2020 08:31
Copy link
Contributor

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 8, 2020

This will be in the next stable release v1.1.0, it shouldn't take long. I'm planning to wrap things up and tag a release candidate this weekend. Until then you can pick up a master build from https://hub.docker.com/r/meltwater/drone-cache/tags?page=1&ordering=last_updated to use in your pipeline.

@kakkoyun kakkoyun merged commit 0bf95f8 into meltwater:master Apr 8, 2020
@lafriks lafriks deleted the feat/rebuild_override branch April 8, 2020 08:37
@lafriks
Copy link
Contributor Author

lafriks commented Apr 8, 2020

Could you restart drone master build task? :)

@kakkoyun
Copy link
Contributor

kakkoyun commented Apr 8, 2020

CI is killing me 😓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache is always rebuilding
2 participants