Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clock selection #626

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix clock selection #626

merged 2 commits into from
Oct 27, 2023

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Oct 4, 2023

No description provided.

@mat-hek mat-hek requested a review from FelonEkonom October 4, 2023 12:15
@mat-hek mat-hek marked this pull request as ready for review October 4, 2023 12:15
@mat-hek mat-hek force-pushed the disable-auto-clock branch from 8341444 to 3df8e64 Compare October 4, 2023 13:29
FelonEkonom
FelonEkonom reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we spoke, let's delete clock_provider from spec options and move this functionality to a new action

lib/membrane/core/parent/clock_handler.ex
Comment on lines +27 to +28
clock = get_clock_from_provider(components, provider)
set_clock_provider(clock, state)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clock = get_clock_from_provider(components, provider)
set_clock_provider(clock, state)
get_clock_from_provider(components, provider)
|> set_clock_provider(clock, state)

@mat-hek mat-hek requested a review from FelonEkonom October 20, 2023 14:18
@FelonEkonom FelonEkonom removed their request for review October 23, 2023 13:45
@mat-hek mat-hek force-pushed the disable-auto-clock branch from 004fc9e to 3df8e64 Compare October 23, 2023 13:46
@mat-hek mat-hek changed the title disable automatic clock selection Fix clock selection Oct 23, 2023
@mat-hek mat-hek requested a review from FelonEkonom October 23, 2023 14:28
@mat-hek mat-hek force-pushed the disable-auto-clock branch from 3df8e64 to f849f80 Compare October 23, 2023 14:28
@mat-hek mat-hek force-pushed the disable-auto-clock branch from f849f80 to 6040706 Compare October 23, 2023 15:19
@mat-hek mat-hek merged commit 519082c into master Oct 27, 2023
1 check passed
@mat-hek mat-hek deleted the disable-auto-clock branch October 27, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelonEkonom FelonEkonom FelonEkonom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Smackore
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mat-hek @FelonEkonom