Add info about change in default flow control value #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
mat-hek
requested changes
Nov 6, 2023
guides/upgrading/v1.0.0.md
Outdated
| @@ -51,6 +51,24 @@ end | |||
| end | |||
| ``` | |||
|
|
|||
| ### Adjust to change in default `flow_control` (aka. `mode`/`demand_mode`) value. | |||
|
|
|||
| Now, if definition of pad in element does specify type of | |||
guides/upgrading/v1.0.0.md
Outdated
|
|
||
| Now, if definition of pad in element does specify type of | ||
|
|
||
| Now, the default value of `flow_control` option in `def_input_pad` and `def_output_pad` in Elements is `:auto`. Until `v0.12.9`, pads that sepcified neither `flow_control`, `mode` nor `demand_mode` explicitly would have `:manual` `flow_control`. Therefore, `:manual` pads that haven't specified `flow_control` value, now have to do it explicitly. |
There was a problem hiding this comment.
I believe it only affects outputs, because for inputs you have to specify demand_unit
mat-hek
reviewed
Nov 7, 2023
guides/upgrading/v1.0.0.md
Outdated
Comment on lines
100
to
101
| - def_output_pad :input, accepted_format: %MyStruct{field: :value} | ||
| + def_output_pad :input, accepted_format: %MyStruct{field: :value}, flow_control: :manual |
There was a problem hiding this comment.
Suggested change
| - def_output_pad :input, accepted_format: %MyStruct{field: :value} | |
| + def_output_pad :input, accepted_format: %MyStruct{field: :value}, flow_control: :manual | |
| - def_output_pad :output, accepted_format: %MyStruct{field: :value} | |
| + def_output_pad :output, accepted_format: %MyStruct{field: :value}, flow_control: :manual |
mat-hek
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.