Update CI to use newer python versions #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkjames7
changed the title
gitbuda
reviewed
Apr 30, 2025
.github/workflows/ci.yml
Outdated
| - {platform: 'ubuntu-24.04', python_version: '3.11', mgversion: 'latest'} | ||
| - {platform: 'ubuntu-24.04', python_version: '3.12', mgversion: 'latest'} | ||
| - {platform: 'ubuntu-24.04', python_version: '3.13', mgversion: 'latest'} | ||
| - {platform: 'fedora-41', python_version: '3.13', mgversion: 'latest'} |
There was a problem hiding this comment.
Fedora 42 is actually latest, not critical to change!
gitbuda
reviewed
Apr 30, 2025
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| docker cp $LOCAL_PACKAGE_NAME testcontainer:/$LOCAL_PACKAGE_NAME |
There was a problem hiding this comment.
Move to a script that could be run independently of Github
gitbuda
reviewed
Apr 30, 2025
.github/workflows/ci.yml
Outdated
| run: python3 -m pip install ./dist/pymgclient-* | ||
| run: | | ||
| docker exec -i testcontainer \ | ||
| bash -c "python3 -m pip install ${{ env.STATIC_SSL }} ./pymgclient/dist/pymgclient-* ${{ env.BREAK_PACKAGES }}" |
There was a problem hiding this comment.
change to the wheel + distribute the static code version as well
gitbuda
reviewed
Apr 30, 2025
Comment on lines
+267
to
+268
| # nohup /usr/lib/memgraph/memgraph --bolt-port 7687 --bolt-cert-file="" --bolt-key-file="" --data-directory="~/memgraph/data" --storage-properties-on-edges=true --storage-snapshot-interval-sec=0 --storage-wal-enabled=false --data-recovery-on-startup=false --storage-snapshot-on-exit=false --telemetry-enabled=false --log-level=TRACE --log-file='$HOME/memgraph/memgraph.log' & | ||
| # nohup /usr/lib/memgraph/memgraph --telemetry-enabled=False & |
gitbuda
reviewed
Apr 30, 2025
Comment on lines
+248
to
+254
| mgversion=$( | ||
| curl -s https://api.github.com/repos/memgraph/memgraph/releases/latest \ | ||
| | grep -m1 '"tag_name":' \ | ||
| | sed -E 's/.*"([^"]+)".*/\1/' \ | ||
| | sed 's/^v//' | ||
| ) | ||
| echo "MGVERSION=$mgversion" >> $GITHUB_ENV |
gitbuda
reviewed
Apr 30, 2025
| nohup /usr/lib/memgraph/memgraph --bolt-port 7687 --bolt-cert-file="cert.pem" --bolt-key-file="key.pem" --data-directory="~/memgraph/data" --storage-properties-on-edges=true --storage-snapshot-interval-sec=0 --storage-wal-enabled=false --storage-snapshot-on-exit=false --telemetry-enabled=false --log-file='' & | ||
| # nohup /usr/lib/memgraph/memgraph --bolt-port 7687 --bolt-cert-file="" --bolt-key-file="" --data-directory="~/memgraph/data" --storage-properties-on-edges=true --storage-snapshot-interval-sec=0 --storage-wal-enabled=false --data-recovery-on-startup=false --storage-snapshot-on-exit=false --telemetry-enabled=false --log-level=TRACE --log-file='$HOME/memgraph/memgraph.log' & | ||
| # nohup /usr/lib/memgraph/memgraph --telemetry-enabled=False & | ||
| sleep 1 |
There was a problem hiding this comment.
another candidate for centralized wait function
gitbuda
reviewed
Apr 30, 2025
Comment on lines
+301
to
+305
| # - '3.9' # this does work, but is old | ||
| - '3.10' | ||
| - '3.11' | ||
| - '3.12' | ||
| - '3.13' |
There was a problem hiding this comment.
remove the comment + align (1 space)
gitbuda
requested changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: requires #73 to be merged into
mgclientand then updating the submodule here before merging!!!