Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tx confirmation status in bulk /block/txs response #41

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Include tx confirmation status in bulk /block/txs response #41

merged 2 commits into from
Nov 13, 2023

Conversation

mononaut
Copy link
Contributor

@mononaut mononaut commented Sep 5, 2023 •
edited
Loading

(builds on #38)

Fixes mempool/mempool#4229 by adding the missing confirmation status field to all transactions in the response from /internal/block/:hash/txs:

"status": {
 "confirmed": true,
 "block_height": ...,
 "block_hash": ...,
 "block_time": ...
}

Also sets the TTL based on the block depth.

@mononaut mononaut force-pushed the mononaut/block-tx-confs branch from 0e03188 to 13cc907 Compare September 5, 2023 23:37
@wiz wiz requested review from softsimon and junderw September 10, 2023 10:16
junderw
junderw approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The deploy needs to be timed properly with other deploys to ensure the right endpoint is being used.

@mononaut mononaut force-pushed the mononaut/block-tx-confs branch from 13cc907 to ae9fc93 Compare November 12, 2023 06:30
@mononaut
Copy link
Contributor Author

rebased on #38

wiz
wiz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ de99ae3

@wiz wiz merged commit 294a8e1 into mempool Nov 13, 2023
7 checks passed
@wiz wiz deleted the mononaut/block-tx-confs branch November 13, 2023 06:09
@softsimon softsimon mentioned this pull request Nov 16, 2023
Open
SatoKentaNayoro pushed a commit to boolnetwork/mempool-electrs that referenced this pull request Nov 29, 2024
@wiz
Merge pull request mempool#41 from mempool/mononaut/block-tx-confs
956f71d 
Include tx confirmation status in bulk /block/txs response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

@wiz wiz wiz approved these changes

@softsimon softsimon Awaiting requested review from softsimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API returning that tx is not confirmed which is not true
4 participants
@mononaut @wiz @junderw @softsimon