Fixed regression introduced by #51 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit merged as part of mempool#51 introduced a regression that prevents the daemon from breaking from its startup wait loop when running in `regtest` mode, and the blockchain already contains 1 or more blocks (apart from genesis). This commit fixes the regression by only checking the equivalence between blocks and headers as the wait condition when running in `regtest` mode.
gslandtreter
force-pushed
the
fix-regtest-startup
branch
from
6bca466 to
1abe9c4
Compare
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
Fixed regression introduced by mempool#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit merged as part of #51 introduced a regression that prevents the daemon from breaking out its startup wait loop when running in
regtestmode, in scenarios where the blockchain already contains 1 or more blocks (apart from genesis).This commit fixes the regression by only checking the equivalence between blocks and headers as the wait condition when running in
regtestmode.