fix: Handle error during decompression #1665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the decompression and therefore installation of the directory artifact the return value is not checked. If the decompression fails (e.g. due to size constraints) the artifact install process continues in the same way it would for an successful decompression. This can leave the system in a corrupted state with a partially installed update. This change fixes the issue by explicitly checking the return value of the decompression process and returning an error code in case of a failure. Changelog: None Ticket: None Signed-off-by: Friedrich Melchert <[email protected]>
friedrich-melchert
changed the title
ghost
self-assigned this
ghost
reviewed
Sep 17, 2024
| if ! tar -cf ${prev_files_tar} -C ${dest_dir} . | ||
|
|
||
| tar -cf ${prev_files_tar} -C ${dest_dir} . | ||
| createPrevSuccess=$? |
There was a problem hiding this comment.
I think this won't work as intended because set -e is active. It will simply stop at the tar command once there is an error, because it's not part of a conditional, and won't continue to the next line.
I can't really see the problem with the previous code though, it looks correct to me. ret is being set, and is returned, as it should. The only thing missing is a more descriptive message. Are you saying this didn't work correctly for you?
Comment on lines
41
to
+46
| tar -xf ${update_files_tar} -C ${dest_dir} | ||
| extractSuccess=$? | ||
| if [ $extractSuccess -ne 0 ] | ||
| then | ||
| echo "Fatal error: something went wrong during artifact installation" | ||
| exit $extractSuccess |
There was a problem hiding this comment.
Here too: This code will never be reached because of set -e.
|
Closing due to inactivity by the author. @friedrich-melchert Feel free to re-open if you have feedback on the provided review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the decompression and therefore installation of the directory artifact the return value is not checked.
If the decompression fails (e.g. due to size constraints) the artifact install process continues in the same way it would for an successful decompression. This can leave the system in a corrupted state with a partially installed update.
This change fixes the issue by explicitly checking the return value of the decompression process and returning an error code in case of a failure.
Changelog: None
Ticket: None