-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIA-886] Global Platform static IP + DocGen IP whitelisting #8775
Conversation
@@ -66,6 +68,21 @@ If you apply IP restrictions to your AWS IAM user or role, you must ensure that | |||
* `10.10.136.0/21` | |||
* `10.10.144.0/21` | |||
|
|||
### Global platform {#global-platform-ips} | |||
|
|||
Services running on our global platform infrastructure (such as the PDF Document Generation service) use the following sets of IP addresses. If you use these services and you apply IP restrictions to your app, you must ensure that the following IP addresses are allowed in your policy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe should be something like Some services
as only a few of them are pointing to the Global Accelerator (static IP), others are pointing the the ALB directly (IP might change anytime).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted
@@ -25,7 +25,7 @@ The [PDF Document Generation](https://marketplace.mendix.com/link/component/2115 | |||
{{% alert color="info" %}}For all deployment types except for on-premises, we only support apps that allow bi-directional communication with the PDF Service in Mendix Cloud.{{% /alert %}} | |||
|
|||
* The maximum file size is 25 MB per document. If your document exceeds this limit, the action will result in an exception. We recommend compressing high-resolution images to reduce their file size. | |||
* When you deploy your app, it needs to be accessible to our cloud service. This requires the restriction type in the Cloud Portal to be set to *Allow all access* for the top-level path (`/`) and the DocGen request handler (`/docgen/`). If your app is configured to [restrict access for incoming requests](/developerportal/deploy/access-restrictions/), for example using IP whitelisting and/or client certificates, our cloud service will not be able to reach your app and the module will not work properly. | |||
If your app is configured to [restrict access for incoming requests](/developerportal/deploy/access-restrictions/) using client certificates, our cloud service will not be able to reach your app and the module will not work properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should start with an * since it's a separate bullet point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
@KevinVlaanderen Hi Kevin, I've reviewed your PR. Should I merge it immediately or wait for the go ahead? |
Feel free to merge it. Thanks a lot for the review! |
No description provided.