Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1671] Disable JSC for MiN #50

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[MOO-1671] Disable JSC for MiN #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c49a1e1
Disable Hermes for MiN
furkanarabaci Dec 9, 2024
fcde1a6
update Podfile.lock
stelselim Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,7 @@ dependencies {
}

// Javascript engine
if (hermesEnabled.toBoolean()) {
implementation("com.facebook.react:hermes-android")
} else {
implementation jscFlavor
}
implementation("com.facebook.react:hermes-android")

// Mendix dependencies
implementation project(":mendixnative-release")
Expand Down
5 changes: 1 addition & 4 deletions android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,4 @@ BUILD_RN_FROM_SOURCE=false
reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
android.suppressUnsupportedCompileSdk=33
android.defaults.buildfeatures.buildconfig=true
android.nonTransitiveRClass=true
# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
hermesEnabled=false
android.nonTransitiveRClass=true
6 changes: 0 additions & 6 deletions ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,11 @@ if linkage != nil
use_frameworks! :linkage => linkage.to_sym
end

# Force libraries to disable hermes usage
ENV["USE_HERMES"] = "0"

abstract_target "Mendix" do
config = use_native_modules!

use_react_native!(
:path => config[:reactNativePath],
# Hermes is now enabled by default. Disable by setting this flag to false.
:hermes_enabled => false,
:fabric_enabled => false,
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
pod 'react-native-ble-plx', :path => '../node_modules/react-native-ble-plx'
Expand Down
Loading