Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1776] upgrade rn to v0.77.0 #961

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

vadymv-mendix
Copy link
Collaborator

@vadymv-mendix vadymv-mendix commented Feb 7, 2025

Description

Please provide a clear and concise description of what this pull request addresses.

Checklist

To ensure this pull request meets the requirements for merging, please complete the checklist below:

  • Release Note: I have added a release note in the Mendix Docs repository relevant to the changes introduced in this PR.
    • Link to release note: [Provide the link here]
  • Breaking Changes: This PR introduces breaking changes (e.g., changes that require updates to existing configurations, dependencies).
    • Requires a new version of Native Mobile Resources
    • Minimum supported Android version is 7
    • Minimum supported iOS version is 15.5

Important Notes

  • PRs will not be merged without a corresponding release note update in the Mendix Docs repository.
  • Make sure the release note accurately describes the changes and impacts introduced by this PR.

ios/Podfile Outdated
# Use it to require both react-native's and this package's scripts:
node_require('react-native/scripts/react_native_pods.rb')
node_require('react-native-permissions/scripts/setup.rb')

require_relative './mendix_utils'

deployment_target = "13.4"
deployment_target = "15.1"
Copy link
Contributor

@mgroeneweg mgroeneweg Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use target 15.5, this works for ZIP archive support and some other libraries in NativeFileDocuments. Saves me and anyone using NativeFileDocuments zip support from changing this manually with each template update.

Edit: Please set the Xcode minimum iOS target to 15.5 as well.

Thanks in advance!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jonathan asked me to put in an example as well, this is the error that is shown when the pod target is set lower than 15.5:

Specs satisfying the RNZipArchive (from ../node_modules/react-native-zip-archive) dependency were found, but they required a higher minimum deployment target.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Marcel, the min iOS version is set to 15.5 now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants