-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOO-1776] upgrade rn to v0.77.0 #961
base: master
Are you sure you want to change the base?
Conversation
ios/Podfile
Outdated
# Use it to require both react-native's and this package's scripts: | ||
node_require('react-native/scripts/react_native_pods.rb') | ||
node_require('react-native-permissions/scripts/setup.rb') | ||
|
||
require_relative './mendix_utils' | ||
|
||
deployment_target = "13.4" | ||
deployment_target = "15.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use target 15.5, this works for ZIP archive support and some other libraries in NativeFileDocuments. Saves me and anyone using NativeFileDocuments zip support from changing this manually with each template update.
Edit: Please set the Xcode minimum iOS target to 15.5 as well.
Thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jonathan asked me to put in an example as well, this is the error that is shown when the pod target is set lower than 15.5:
Specs satisfying the
RNZipArchive (from ../node_modules/react-native-zip-archive
) dependency were found, but they required a higher minimum deployment target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Marcel, the min iOS version is set to 15.5 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Description
Please provide a clear and concise description of what this pull request addresses.
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
Important Notes