Skip to content

fix: support resume download for /pull #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request introduces several improvements and new features to the download service in the engine. The most important changes include adding support for resuming downloads, enhancing logging for download progress, and refactoring the GetDownloadTask function.

Enhancements to download functionality:

  • engine/services/download_service.cc: Added logic to check for existing files and resume downloads if the file is partially downloaded. This includes updating the file open mode to "ab" for appending and setting the CURLOPT_RESUME_FROM_LARGE option in SetUpCurlHandle to resume downloads. [1] [2] [3] [4]

Logging improvements:

  • engine/services/download_service.cc: Enhanced logging to provide more detailed information about the download process, including the size of existing files and the number of bytes needed to complete the download.

Refactoring and code cleanup:

Minor fixes:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev force-pushed the fix/resume-download branch 2 times, most recently from 34f02a3 to 2041171 Compare February 12, 2025 03:15
@vansangpfiev vansangpfiev marked this pull request as ready for review February 12, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants