WIP: Small refactoring #2188
Draft
WIP: Small refactoring #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selim1903
commented
Apr 1, 2025
| return CommandStatus::Success; | ||
| } catch (const std::exception& e) { | ||
| std::cerr << "Error: " << e.what() << std::endl; | ||
| return CommandStatus::GeneralError; |
There was a problem hiding this comment.
TODO: Need to implement these command status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Cleaned up command structure with proper interfaces
Hey team! This PR cleans up our command architecture to make it more maintainable.
Main idea: keep main.cc super minimal and introduce clean public interfaces with implementations hidden in their own folder structure.
This gives us a much cleaner structure while keeping everything working with the existing code. Also makes it way easier to test!
Fixes Issues
Self Checklist