orphaned answers added to answer pile

mentorpal · Aug 29, 2023 · 19d370a · 19d370a
1 parent bffc860
commit 19d370a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/client/src/hooks/graphql/use-with-review-answer-state.tsx b/client/src/hooks/graphql/use-with-review-answer-state.tsx
@@ -96,7 +96,7 @@ export function useWithReviewAnswerState(
   );
   const mentorQuestions = useQuestions(
     (state) => state.questions,
-    mentorAnswers?.map((a) => a.question)
+    [...(mentorAnswers || []).map((a) => a.question)]
   );
   const questionsLoading = isQuestionsLoading(
     mentorAnswers?.map((a) => a.question)
@@ -108,10 +108,7 @@ export function useWithReviewAnswerState(
   }, [mentorSubjects]);
 
   useEffect(() => {
-    setAnswers([
-      ...(mentorAnswers || []).map((a) => ({ ...a })),
-      ...(mentorOrphanedCompleteAnswers || []).map((a) => ({ ...a })),
-    ]);
+    setAnswers([...(mentorAnswers || []).map((a) => ({ ...a }))]);
   }, [mentorAnswers]);
 
   useEffect(() => {

diff --git a/client/src/types-gql.ts b/client/src/types-gql.ts
@@ -192,7 +192,10 @@ export function convertMentorGQL(gql: MentorGQL): Mentor {
       ? convertSubjectGQL(gql.defaultSubject)
       : undefined,
     subjects: gql.subjects?.map((s) => convertSubjectGQL(s)),
-    answers: gqlAnswers.map((a) => convertAnswerGQL(a)),
+    answers: [
+      ...gqlAnswers.map((a) => convertAnswerGQL(a)),
+      ...gql.orphanedCompleteAnswers.map((a) => convertAnswerGQL(a)),
+    ],
     orphanedCompleteAnswers: gql.orphanedCompleteAnswers?.map((a) =>
       convertAnswerGQL(a)
     ),

diff --git a/cypress/cypress/integration/index.spec.ts b/cypress/cypress/integration/index.spec.ts
@@ -299,7 +299,7 @@ describe("Index page", () => {
     });
   });
 
-  it("answers that do not belong to any subject exist in their own recording card", () => {
+  it.only("answers that do not belong to any subject exist in their own recording card", () => {
     cyMockDefault(cy, {
       mentor: {
         ...clint,