Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Changed] chalk from peer to dev dependency #3

Closed
wants to merge 4 commits into from

Conversation

alfupe
Copy link
Contributor

@alfupe alfupe commented Nov 2, 2023

📸 Screenshots/Gif/Videos

🎩 What?

Moved chalk to dev from peer dependency. Let's make wrapito-vitest be the responsible for installing it instead of relying on the library consumer to have it installed.

🤔 Why?

It's possible that in the past boilerplate react-scripts was installing chalk and in the new one was installed by Husky or Lint-Staged but since we have removed it we were unable to pass the pipelines due to the lack of the dependency.

🧪 How has this been tested? / 💥 How will I know if this breaks?

🗣️ Comments

[Changed] chalk from peer to dev dependency
@alfupe alfupe self-assigned this Nov 2, 2023
@alfupe alfupe requested a review from a team November 2, 2023 17:36
@alfupe alfupe closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant