Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wip add types for wrap #68

Closed
wants to merge 3 commits into from
Closed

Conversation

arturosdg
Copy link
Contributor

@arturosdg arturosdg commented Nov 8, 2024

📸 Screenshots/Gif/Videos

image

🎩 What?

🤔 Why?

🧪 How has this been tested? / 💥 How will I know if this breaks?

🗣️ Comments

First attempt at adding types to wrap, with this method we can configure the wrap and export a typed wrap for our tests.

I added this "Omit<this, 'withNetwork'>" to avoid using multiple times the same build step, but couldn't find a way to add it to the custom extends

Right now you must pass an empty object as a parameter to any mocks, this should be fixed so we can have helpers without any params.

I used "as Wrap & WrappedExtensions" the types should not be forced, would be ideal to make wrapito infer them to avoid magical things

@arturosdg arturosdg closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant