print_utils: minor cleanups #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
table columns are now always of type `List[str]` and better variable names for the column lists (´*_column´) ... Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Katja Köhler <[email protected]>
andlaus
force-pushed
the
minor_printutils_fixes
branch
from
12b9ad2 to
442d9cb
Compare
|
dependency not actually removed, did you forget to commit a file? |
kayoub5
reviewed
Nov 20, 2024
kayoub5
reviewed
Nov 20, 2024
such notes go into tickets, otherwise they get lost in the commit history |
this is now replaced by `rich.table`. Note to self: the `compare` tool *really* needs cleanup. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Katja Köhler <[email protected]>
andlaus
force-pushed
the
minor_printutils_fixes
branch
from
c11afc9 to
d103e28
Compare
|
in the initial version of the PR I removed the dependency, then the CI complained because |
done: #363 |
kayoub5
reviewed
Nov 20, 2024
thanks to [at]kayoub5 for the nudge! Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Katja Köhler <[email protected]>
kayoub5
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a minor follow-up to #359: table columns are now always of type
List[str], better variable names for the column lists (´*_column´) and removal of the now unusedtabulatedependency...Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information