Feature 3611 zap wrapper webscan template login #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
winzj
commented
Nov 18, 2024
winzj
commented
- closes Implement template login for ZAP wrapper application #3611
- add entry to openapi.yaml - add field with default - extend unit tests - extend examples, documentation and RestDocTest
- add decoder with autodetect method and unit testcases - add seed to totp generator and change signature - update unit testcases
- add parts for script execution with session management - add script authentication to ZapScanner - add necessary dependencies to gradle files - add configuration option via commandline parameter and ENV variable
winzj
changed the title
- add groovy script example to README.adoc - add short explanations - add method to TOTPGenerator to generate a currently valid TOTP - update examples
de-jcup
requested changes
Nov 21, 2024
...ub-commons-model/src/main/java/com/mercedesbenz/sechub/commons/model/login/EncodingType.java
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/configuration/sechub_config.adoc
Show resolved
Hide resolved
sechub-doc/src/docs/asciidoc/documents/shared/configuration/sechub_config.adoc
Show resolved
Hide resolved
| private String hashAlgorithmName; | ||
| private int totpLength; | ||
| private int tokenValidityTimeInSeconds; | ||
| private long digitsTruncate; | ||
|
|
||
| public TOTPGenerator() { | ||
| this(DEFAULT_TOTP_LENGTH, TOTPHashAlgorithm.HMAC_SHA1, DEFAULT_TOKEN_VALIDITY_TIME_IN_SECONDS); | ||
| public TOTPGenerator(String seed) { |
There was a problem hiding this comment.
This constructor is only used inside 2 tests.
Do we really need this one? Or should we create instead a static test helper method inside the tests or something else?
| @Test | ||
| void file_does_not_exist_and_so_no_scan_is_cancelled() throws IOException { | ||
| /* prepare */ | ||
| String scanContextName = UUID.randomUUID().toString(); | ||
| ZapPDSEventHandler zapPDSEventHandler = new ZapPDSEventHandler(""); |
There was a problem hiding this comment.
What about a parameterized test and
injecting "" ," " and null as value parameters?
|
|
||
| /* execute + test */ | ||
| assertFalse(zapPDSEventHandler.isScanCancelled()); | ||
| assertDoesNotThrow(() -> zapPDSEventHandler.cancelScan(scanContextName)); | ||
| } | ||
|
|
||
| @Test | ||
| void file_does_exist_and_so_scan_is_cancelled(@TempDir File tempDir) throws IOException { | ||
| void file_does_exist_and_so_scan_is_cancelled(@TempDir Path tempDir) throws IOException { |
There was a problem hiding this comment.
whabt about file DOES NOT exist case? should we add an additional test here?
| private StringDecoder supportToTest = new StringDecoder(); | ||
|
|
||
| @Test | ||
| void when_secret_key_is_null_an_exception_is_thrown() { |
There was a problem hiding this comment.
What if secret key is blank ("", " ") -> is this a valid key?
It is not tested in any test, so i am not sure
There was a problem hiding this comment.
What happens when encoding type is null, or different? Should this be tested as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.