-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#45: Add reusable workflows #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool, thanks @ddundo. Just one minor suggestion.
@jwallwork23 maybe I could also remove
from the Makefiles and add it centrally to |
I'd prefer to keep it in so that users and developers can run locally. |
Actually, you're right - it's probably not necessary for this to be duplicated across all the repos. The citation isn't going to change that often either. Let's remove it from the Makefile. |
Great, thanks! I made these changes and tested it on Animate mesh-adaptation/animate#148 so I'll merge :) |
Closes #45.
After this is merged I will change
citation_check.yml
in Animate/Goalie/Movement to be:and
test_suite.yml
in Animate will be:and similarly for Goalie and Movement.