Allow switching Docker image in reusable test workflow #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
testing
ddundo
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Looks good! I tested it on Animate to see if it would work and it does (https://github.com/mesh-adaptation/animate/actions/runs/11987242482/job/33421183585). I didn't know if the string format 'firedrake-parmmg' with the quotation marks would mess it up, since I saw that in mesh-adaptation/UM2N#59 you passed firedrake-um2n without the quotation marks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66.
Required for the completion of mesh-adaptation/UM2N#59.
Note that the option defaults to
firedrake-parmmgso that we only need to provide this for the UM2N test suite.