Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UM2N container in build_docs.yml #89

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Use UM2N container in build_docs.yml #89

merged 3 commits into from
Dec 12, 2024

Conversation

ddundo
Copy link
Member

@ddundo ddundo commented Dec 11, 2024

Now that #88 made firedrake-um2n use firedrake-parmmg as base, we can use firedrake-um2n container to build docs.

And I think that just git pull is enough to get the latest changes to our packages, right? Since they're installed in editable mode (pip install -e)

@ddundo ddundo self-assigned this Dec 11, 2024
@ddundo ddundo added the optimisation An opportunity to optimise performance label Dec 11, 2024
@ddundo
Copy link
Member Author

ddundo commented Dec 11, 2024

Checked the artifact and it looks good!

@ddundo ddundo requested a review from jwallwork23 December 11, 2024 19:58
@ddundo ddundo merged commit a11c26c into main Dec 12, 2024
3 checks passed
@ddundo ddundo deleted the 4_docs_ci_um2n branch December 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation An opportunity to optimise performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants