Mixed steady/unsteady #164
Conversation
ddundo
added
bug
This reverts commit 203ed27.
|
@jwallwork23 I converted this demo to just solve the forward problem, since it doesn't seem like adjoint-related issues will be solved anytime soon (and I don't plan on doing goal-oriented adaptation anytime soon) |
There was a problem hiding this comment.
Thanks @ddundo, no worries about it being forward only. Always nice to have more demos.
This mostly looks good but I have a couple of requests and a few suggested edits.
I was thinking about where the demo might fit in the sequence, but since we have quite a few now and users are unlikely to go through all of them in order, we might need to rethink if/how demos follow on from each other. So I guess it's okay for this one to be standalone.
|
|
||
| # We consider the problem of a mantle convection in a 2D unit square domain. The | ||
| # governing equations and Firedrake implementation are based on the 2D Cartesian | ||
| # incompressible isoviscous case from :cite:`Davies:2022`. We refer the reader to the |
There was a problem hiding this comment.
Please open a linked docs PR adding this to follow mesh-adaptation/docs#64.
There was a problem hiding this comment.
I made a suggestion in that PR to add it since it's still open :) https://github.com/mesh-adaptation/mesh-adaptation-docs/pull/64/files#r1855525732
There was a problem hiding this comment.
You'll also need to add it on the goalie/index.rst page.
There was a problem hiding this comment.
Thanks! Opened mesh-adaptation/docs#70
Co-authored-by: Joe Wallwork <[email protected]>
|
Thanks for the suggestions @jwallwork23!
Good point. I'll just add it after Gray-Scott demos for now :) |
|
|
||
| # We consider the problem of a mantle convection in a 2D unit square domain. The | ||
| # governing equations and Firedrake implementation are based on the 2D Cartesian | ||
| # incompressible isoviscous case from :cite:`Davies:2022`. We refer the reader to the |
There was a problem hiding this comment.
You'll also need to add it on the goalie/index.rst page.
Related to the Goalie demo mesh-adaptation/goalie#164
Closes #152: added a mantle convection demo (taken from Davies, Kramer et al. 2022)