Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reusable workflows #218

Merged
merged 2 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions .github/workflows/citation_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,4 @@ on:

jobs:
citation_check:
name: 'Check Citation'
runs-on: ubuntu-latest

steps:
- name: 'Check out the repo'
uses: actions/checkout@v4

- name: 'Setup Python'
uses: actions/setup-python@v2
with:
python-version: 3.8

- name: 'Check citation'
run: |
pip install cffconvert
make check_citation
uses: mesh-adaptation/mesh-adaptation-docs/.github/workflows/reusable_citation_check.yml@main
79 changes: 15 additions & 64 deletions .github/workflows/test_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,68 +13,19 @@ on:
schedule:
- cron: '0 1 * * 0'

concurrency:
# Cancel jobs running if new commits are pushed
group: >
${{ github.workflow }}-
${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
build:
name: 'Test suite'
runs-on: ubuntu-latest
container:
image: ghcr.io/mesh-adaptation/firedrake-parmmg:latest
options: --user root
steps:
- name: 'Check out the repo'
id: checkout
uses: actions/checkout@v4

- name: 'Determine files differing from target branch'
id: changed-files
if: ${{ github.event_name != 'push' && github.ref != 'refs/heads/main' }}
uses: tj-actions/changed-files@v44
with:
files: |
.github/workflows/test_suite.yml
**/*.py
**/*.msh
**/*.geo

- name: 'Cleanup'
if: ${{ always() }}
run: |
cd ..
rm -rf build

- name: 'Setup Python'
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || (steps.changed-files.outcome == 'success' && steps.changed-files.outputs.any_changed == 'true') || github.event_name == 'schedule' }}
uses: actions/setup-python@v2
with:
python-version: 3.8

- name: 'Install Goalie'
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || (steps.changed-files.outcome == 'success' && steps.changed-files.outputs.any_changed == 'true') || github.event_name == 'schedule' }}
run: |
. /home/firedrake/firedrake/bin/activate
python -m pip uninstall -y goalie
python -m pip install -e .

- name: 'Lint'
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || (steps.changed-files.outcome == 'success' && steps.changed-files.outputs.any_changed == 'true') || github.event_name == 'schedule' }}
run: |
. /home/firedrake/firedrake/bin/activate
make lint

- name: 'Test Goalie'
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/main') || (steps.changed-files.outcome == 'success' && steps.changed-files.outputs.any_changed == 'true') || github.event_name == 'schedule' }}
run: |
. /home/firedrake/firedrake/bin/activate
python $(which firedrake-clean)
export GITHUB_ACTIONS_TEST_RUN=1
python -m coverage erase
python -m coverage run -a --source=goalie -m pytest -v --durations=20 test
python -m coverage run -a --source=goalie -m pytest -v --durations=10 test_adjoint
python -m coverage report
test_suite:
uses: mesh-adaptation/mesh-adaptation-docs/.github/workflows/reusable_test_suite.yml@main
with:
install-command: 'python -m pip uninstall -y goalie && python -m pip install -e .'
test-command: |
python $(which firedrake-clean)
export GITHUB_ACTIONS_TEST_RUN=1
python -m coverage erase
python -m coverage run -a --source=goalie -m pytest -v --durations=20 test
python -m coverage run -a --source=goalie -m pytest -v --durations=10 test_adjoint
python -m coverage report
changed-files-patterns: |
**/*.py
**/*.msh
**/*.geo
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@ demo:
@cd demos && make
@echo "Done."

check_citation:
@echo "Checking CITATION.cff formatting..."
@cffconvert --validate
@echo "PASS"

tree:
@tree -d .

Expand Down
Loading