Add linting, pre-commit, and CI #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pre-commit and fix style errors * Add CI to enforce pre-commit * Update .gitignore * Update Readme
|
@RussTedrake , just tagging you on this PR in advance of our meeting tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides several infrastructure related improvements to Meshcat, primarily in the form of a linter, according to the JavaScript Standard Style. A bulk of the linter errors have been addressed already, with the exception of the following (disabled via comment in
src/index.js):In addition,
pre-commit run --all-filesmaster).gitignorePlease note that GitHub repos have a setting called "run workflows from fork pull requests" - it seems that this is disabled right now, which is why the CI is not triggering. The CI result from my fork can be found here.