[WIP] Set GPS to stationary mode when fixed position is enabled #6630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untested WIP - this code may never run, need to check where GPS setup bails out due to fixed_position config. As repoted by @RCGV1, some GPS chips have a "stationary" mode, which assumes acceleration and velocity are zero. For fixed nodes, taking advantage of this configuration means potentially less power usage, and a more accurate position that doesn't jitter its way around the map. (See also: meshtastic#3984 ) The aim would be to enable this mode when users have a GPS enabled and select "Fixed Position" without specifying coordinates. UX TBD! Fixes meshtastic#6627
|
Fixed position does not generally use the gps at all, I would suggest the stationary mode should not need any UX at all and instead not use power or generate positions all over the place when the gps detects it is stationary. For this to be done well it should reduce the positions sent over the mesh, save power and not require any more position settings as there are already far too many. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested WIP - this code may never run, need to check where GPS setup bails out due to fixed_position config.
As reported by @RCGV1, some GPS chips have a "stationary" mode, which assumes acceleration and velocity are zero. For fixed nodes, taking advantage of this configuration means potentially less power usage, and a more accurate position that doesn't jitter its way around the map. (See also: #3984 )
This patch makes changes to the setup code for the the GNSS_MODEL_MTK, GNSS_MODEL_MTK_L76B, GNSS_MODEL_ATGM336H, GNSS_MODEL_AG3335, GNSS_MODEL_AG3352 to apply that approach.
The aim would be to enable this mode when users have a GPS enabled and select "Fixed Position" without specifying coordinates. UX TBD!
Fixes #6627
🤝 Attestations