Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bit field to DeviceMetadata for excluded modules #614

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add bit field to DeviceMetadata for excluded modules #614

merged 1 commit into from
Nov 4, 2024

Conversation

andrekir
Copy link
Member

@andrekir andrekir commented Nov 3, 2024

adds bit field to DeviceMetadata for tracking excluded modules

@caveman99
Copy link
Member

I think NONE needs to be renamed. Clashes with other stuff

thebentern
thebentern reviewed Nov 3, 2024
View reviewed changes
@andrekir
Copy link
Member Author

andrekir commented Nov 4, 2024

Renamed NONE to EXCLUDED_NONE to make it unique and avoid conflicts with other enums.

@thebentern thebentern merged commit 06cf134 into master Nov 4, 2024
2 checks passed
@thebentern thebentern deleted the module_validation branch November 4, 2024 10:55
@andrekir andrekir mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caveman99 caveman99 caveman99 approved these changes

@thebentern thebentern thebentern approved these changes

@garthvh garthvh Awaiting requested review from garthvh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrekir @caveman99 @thebentern