Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable map control #153

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

emailvomitcomet
Copy link
Contributor

I found that map control wasn't working after the initial map load with peers. The map view would be set to a bounding box around my peers but would then become unresponsive. The buttons in the top right of the map (zoom in/out, bound) would not work.

This was an issue as I'd enabled MQTT while initially testing my node (showing me global peers) but I wanted to zoom in on my own area after disabling it later, which I couldn't do. I adjusted this initial behaviour to occur once, which then allows the user to interact with the map as expected.

I also adjusted the default "peerless" map location to be zoomed out and central-ish on the map in use, rather than zoomed into Melbourne. There's probably a better solution for this, but for now starting at a high zoom level feels more natural than a specific city - happy to revert this out if you'd prefer to keep things as is.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ emailvomitcomet
❌ Kette N. Krad


Kette N. Krad seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sachaw
Copy link
Member

sachaw commented Jan 15, 2024

Thanks, If you could just please sign the CLA, I'll get this merged.

@emailvomitcomet
Copy link
Contributor Author

Apologies for the delay, I've signed the CLA.

@sachaw sachaw merged commit 8a4950d into meshtastic:master Jan 23, 2024
@emailvomitcomet emailvomitcomet deleted the enable-map-control branch January 30, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants