Apply suggestions from code review

mesonbuild · Jul 29, 2024 · 6a600f1 · 6a600f1
1 parent d754adf
commit 6a600f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/run_project_tests.py b/run_project_tests.py
@@ -911,8 +911,7 @@ def load_test_json(t: TestDef, stdout_mandatory: bool, skip_category: bool = Fal
             exclude = False
             opt_tuple = [(x[0], x[1]) for x in i]
             for j in matrix['exclude']:
-                ex_list = list(j.items())
-                if all(x in opt_tuple for x in ex_list):
+                if all(x in opt_tuple for x in j.items()):
                     exclude = True
                     break
 

diff --git a/unittests/allplatformstests.py b/unittests/allplatformstests.py
@@ -568,8 +568,7 @@ def test_install_introspection_multiple_outputs(self):
     def read_install_logs(self):
         # Find logged files and directories
         with Path(self.builddir, 'meson-logs', 'install-log.txt').open(encoding='utf-8') as f:
-            return [Path(l.strip()) for l in filter(lambda l: not l.startswith('#'),
-                                     f.readlines())]
+            return [Path(l.strip()) for l in f.readlines() if not l.startswith('#')]
 
     def test_install_log_content(self):
         '''