Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in example Python module option #13838

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

LSgeo
Copy link
Contributor

@LSgeo LSgeo commented Oct 30, 2024

python.install_env is the correct command, as documented in https://mesonbuild.com/Builtin-options.html#python-module.

python.install_venv causes an error, it is not immediately obvious that the slight typo is the cause.

@LSgeo LSgeo requested a review from jpakkane as a code owner October 30, 2024 04:58
Copy link
Member

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the fix looks reasonable. Can you reformat the commit message a bit so that it follows markdown style paragraph formatting -- i.e. line breaks at ~72 / ~80 columns.

e.g.

Correct typo in example Python module option

python.install_env is the correct command, as documented in
https://mesonbuild.com/Builtin-options.html#python-module.

python.install_venv causes an error, it is not immediately obvious that
the slight typo is the cause.

python.install_env is the correct command, as documented
in https://mesonbuild.com/Builtin-options.html#python-module.

python.install_venv causes an error, it is not immediately obvious
that the slight typo is the cause.
@eli-schwartz eli-schwartz merged commit a608e56 into mesonbuild:master Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants