-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorganize networking docs #1225
base: master
Are you sure you want to change the base?
Conversation
"instances":1, | ||
"backoffFactor":1.14472988585, | ||
"backoffSeconds":5, | ||
"ipAddress":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ipAddress property is obsolete.
"container":{ | ||
"type":"DOCKER", | ||
"docker":{ | ||
"network":"USER", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network property is now networks and is at the app definition level, not under docker. There is no such value "USER". It's either host, container, container/bridge.
"docker":{ | ||
"network":"USER", | ||
"image":"busybox", | ||
"portMappings":[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The portMappings property was moved. It's now under container.
} | ||
``` | ||
|
||
Learn more about ports and networking in [Marathon](/docs/1.10/deploying-services/service-ports/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ports topic is out of date wrt network/networks.
@@ -1,6 +1,6 @@ | |||
--- | |||
post_title: Securing communication with TLS | |||
menu_order: 06 | |||
menu_order: 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be removing this from networking
.
@@ -5,73 +5,60 @@ feature_maturity: preview | |||
menu_order: 04 | |||
--- | |||
|
|||
DC/OS supports Container Networking Interface (CNI)-compatible virtual networking solutions, including [Calico](https://github.com/dcos/examples/tree/master/calico) and Contrail. DC/OS also provides a native virtual networking solution called DC/OS Overlay. | |||
DC/OS supports Container Networking Interface (CNI)-compatible virtual networking solutions, including [Calico](https://github.com/dcos/examples/tree/master/calico) and Contrail. DC/OS also provides a native virtual networking solution called DC/OS Overlay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is very specific to CNI, and we should move into the CNI section.
|
||
# DC/OS Overlay | ||
DC/OS Overlay provides an IP per container for Mesos and Docker containers alike. DC/OS Overlay uses CNI (Container Network Interface) for the [Mesos Containerizer](http://mesos.apache.org/documentation/latest/containerizers/#Mesos) and Docker libnetwork for the [Docker Containerizer](http://mesos.apache.org/documentation/latest/containerizers/#Docker). | ||
# Virtual Networks on DC/OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to re-write this entire section. This section is very specific to DC/OS overlay. We need an intro section over which talks about container networking in DC/OS and how DC/OS enables it using CNI and CNM standards. We can then have sections on CNI and CNM and DC/OS overlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to share some content on a word doc for this section later tonight.
@pavisandhu Assigning this to you for reference |
Description
Urgency
Requirements