Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to go 1.23.4 #21

Merged
merged 15 commits into from
Jan 15, 2025
Merged

feat: upgrade to go 1.23.4 #21

merged 15 commits into from
Jan 15, 2025

Conversation

SandhyaRavi2403
Copy link

What this PR does / why we need it:
update go version

Which issue(s) this PR fixes
https://jira.nutanix.com/browse/NCN-104688

Special notes for your reviewer:

@SandhyaRavi2403 SandhyaRavi2403 self-assigned this Jan 6, 2025
@SandhyaRavi2403 SandhyaRavi2403 requested a review from a team as a code owner January 6, 2025 18:10
@takirala takirala marked this pull request as draft January 6, 2025 23:17
@takirala
Copy link

takirala commented Jan 6, 2025

The project failed to compile it looks like. Lets make sure CI is 🟢 before requesting reviews. I moved the PR back to draft meanwhile. Thanks!

@ArvinderPal09 ArvinderPal09 marked this pull request as ready for review January 7, 2025 04:40
@ArvinderPal09 ArvinderPal09 marked this pull request as draft January 7, 2025 06:21
@ArvinderPal09
Copy link

Hi @dkoshkin
Could you please review it once and suggest me something here.

@ArvinderPal09 ArvinderPal09 requested a review from dkoshkin January 7, 2025 07:37
@mhrabovcin
Copy link

@ArvinderPal09 could you please bump the golangci-lint dependency, which will work correctly with go 1.23.4 - https://github.com/mesosphere/kubefed/blob/master/scripts/download-binaries.sh#L71

@ArvinderPal09
Copy link

@ArvinderPal09 could you please bump the golangci-lint dependency, which will work correctly with go 1.23.4 - https://github.com/mesosphere/kubefed/blob/master/scripts/download-binaries.sh#L71

Sure I will check the compatible version of golangci-lint and bump it.

@ArvinderPal09 ArvinderPal09 force-pushed the sandy/update-dependencies branch 2 times, most recently from a2f36a2 to 865d8f0 Compare January 10, 2025 13:40
@ArvinderPal09
Copy link

@mhrabovcin
Could you please suggest me something here.

We already have the higher version but it is still asking for the golang upgrades.

@mhrabovcin
Copy link

@ArvinderPal09 https://github.com/mesosphere/kubefed/blob/master/Makefile#L56 golang version needs to be bumped.

@ArvinderPal09 ArvinderPal09 force-pushed the sandy/update-dependencies branch from 6af0720 to fe63790 Compare January 13, 2025 09:49
@ArvinderPal09 ArvinderPal09 force-pushed the sandy/update-dependencies branch from 7dc0c5b to 38b1ab0 Compare January 13, 2025 10:49
@ArvinderPal09 ArvinderPal09 force-pushed the sandy/update-dependencies branch 6 times, most recently from 0a5c945 to 849dbb7 Compare January 15, 2025 04:22
@SandhyaRavi2403 SandhyaRavi2403 requested review from mhrabovcin and removed request for dkoshkin January 15, 2025 08:52
@ArvinderPal09 ArvinderPal09 marked this pull request as ready for review January 15, 2025 10:07
@mhrabovcin mhrabovcin merged commit 76d343b into master Jan 15, 2025
2 checks passed
This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants