-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to go 1.23.4 #21
Conversation
The project failed to compile it looks like. Lets make sure CI is 🟢 before requesting reviews. I moved the PR back to draft meanwhile. Thanks! |
Hi @dkoshkin |
@ArvinderPal09 could you please bump the golangci-lint dependency, which will work correctly with go 1.23.4 - https://github.com/mesosphere/kubefed/blob/master/scripts/download-binaries.sh#L71 |
Sure I will check the compatible version of golangci-lint and bump it. |
a2f36a2
to
865d8f0
Compare
@mhrabovcin We already have the higher version but it is still asking for the golang upgrades. |
@ArvinderPal09 https://github.com/mesosphere/kubefed/blob/master/Makefile#L56 golang version needs to be bumped. |
6af0720
to
fe63790
Compare
7dc0c5b
to
38b1ab0
Compare
0a5c945
to
849dbb7
Compare
What this PR does / why we need it:
update go version
Which issue(s) this PR fixes
https://jira.nutanix.com/browse/NCN-104688
Special notes for your reviewer: