-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add release please action #22
Conversation
3d0ae61
to
e379a22
Compare
@shubham2g this requires also a github action workflow. https://github.com/googleapis/release-please-action Please see some example in other NKP repos. |
Hi @mhrabovcin Created Github Action Workflow, kindly review. |
.github/workflows/release-please.yml
Outdated
with: | ||
token: ${{ secrets.MESOSPHERECI_USER_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this secret usage.
@shubham2g the action and new files needs some adjustments:
Here is an example of release please action for a public repo - https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/blob/main/.github/workflows/release-please.yml |
.github/workflows/release-please.yml
Outdated
runs-on: | ||
- self-hosted | ||
- small |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a public runner.
.github/workflows/release-please.yml
Outdated
registry: ghcr.io | ||
username: ${{ github.actor }} | ||
password: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these options doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If release-please includes GHCR as part of its release process (e.g., for publishing containerized artifacts or versions), this configuration is essential for authentication. However, if it does not involve pushing or pulling artifacts from GHCR (e.g., it only handles GitHub releases and tags), this block is unnecessary. Since I’m uncertain about the current need for GHCR, it might be safe to omit this block for now and add it later if GHCR interaction becomes required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've chatted via slack - these input values are not supported by the action.
.github/workflows/release-please.yml
Outdated
- uses: googleapis/release-please-action@v4 | ||
id: release-please | ||
with: | ||
release-type: go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be included - we want to ru manifest
release type.
release-type: go |
.github/workflows/release-please.yml
Outdated
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
I don't think that this is necessary.
.github/workflows/release-please.yml
Outdated
git tag -d v${{ steps.release.outputs.major }} || true | ||
git tag -d v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true | ||
git push origin :v${{ steps.release.outputs.major }} || true | ||
git push origin :v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true | ||
git tag -a v${{ steps.release.outputs.major }} -m "Release v${{ steps.release.outputs.major }}" | ||
git tag -a v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} -m "Release v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}" | ||
git push origin v${{ steps.release.outputs.major }} | ||
git push origin v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git tag -d v${{ steps.release.outputs.major }} || true | |
git tag -d v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true | |
git push origin :v${{ steps.release.outputs.major }} || true | |
git push origin :v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true | |
git tag -a v${{ steps.release.outputs.major }} -m "Release v${{ steps.release.outputs.major }}" | |
git tag -a v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} -m "Release v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}" | |
git push origin v${{ steps.release.outputs.major }} | |
git push origin v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} | |
git tag -a ${{ steps.release-please.outputs.tag_name }} -m "Release ${{ steps.release-please.outputs.tag_name }}" | |
git push origin ${{ steps.release-please.outputs.tag_name }} |
.github/workflows/release-please.yml
Outdated
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
.github/workflows/release-please.yml
Outdated
tags: | ||
- 'v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tags: | |
- 'v*' |
This action should run on branches.
chore: Add release please action
Jira Ticket#https://jira.nutanix.com/browse/NCN-104689