Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deploy script for Clojars #27

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add deploy script for Clojars #27

merged 3 commits into from
Aug 30, 2024

Conversation

tsmacdonald
Copy link
Contributor

[Fixes #22]

@camsaul
Copy link
Member

camsaul commented Aug 29, 2024

heads up we're gonna need to add clojars secrets to GH make this work

@tsmacdonald
Copy link
Contributor Author

@camsaul We already did, there's a thread in #ama-corp about it

@tsmacdonald
Copy link
Contributor Author

@camsaul just to highlight that build.clj mostly works as it does for all the other projects, but in this case (and in Macaw) the major.minor prefix is set by the VERSION file.

@tsmacdonald tsmacdonald requested a review from a team August 30, 2024 07:40
@tsmacdonald
Copy link
Contributor Author

Merging this since the real test is Does It Work in main. I'm hopeful!

@tsmacdonald tsmacdonald merged commit daf7e04 into main Aug 30, 2024
3 checks passed
@tsmacdonald tsmacdonald deleted the deploy-to-clojars branch August 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piranha piranha piranha approved these changes

@dpsutton dpsutton Awaiting requested review from dpsutton

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy to Clojars
3 participants
@tsmacdonald @camsaul @piranha