Add :only-tags option
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
approved these changes
Sep 11, 2024
| (tags-set (:ns (meta varr))) | ||
| (tags-set varr)))] | ||
| (printf | ||
| "Skipping `%s` due to missing only tag(s): %s\n" |
There was a problem hiding this comment.
It would be really nice if we rolled up the logs to namespace level when possible, as typically none of the tests will be adding any more tags.
There was a problem hiding this comment.
I'll tackle this separately. It is a little noisy
Comment on lines
+78
to
+81
| (are [options] (= [#'find-tests-test] | ||
| (hawk/find-tests this-ns options)) | ||
| {:only-tags [:exclude-this-test]} | ||
| {:only-tags #{:exclude-this-test}})) |
There was a problem hiding this comment.
These seems to be repeated test cases.
There was a problem hiding this comment.
no a set and vector are not the same and I want to make sure both work
There was a problem hiding this comment.
I meant that they're both duplicates of the tests on line 74 and 75, if I'm not mistaken
|
Apologies for rudely pushing to your branch - Github wouldn't show the right diff without fixing the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to do something super cool with this NGL no cap fr fr