Silence more warnings

metaborg · Jul 10, 2024 · bb16ab2 · bb16ab2
1 parent bdc60d9
commit bb16ab2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/convention-plugin/src/main/kotlin/org/metaborg/convention/JavaConventionPlugin.kt b/convention-plugin/src/main/kotlin/org/metaborg/convention/JavaConventionPlugin.kt
@@ -66,8 +66,11 @@ class JavaConventionPlugin: Plugin<Project> {
                     // Use UTF-8 encoding by default
                     encoding = "UTF-8"
                     charset("UTF-8")
-                    // Silence doclint warnings
+                    // Reduce doclint warnings
+                    addStringOption("Xmaxwarns", "1")
+                    // Silence doclint lints
                     addStringOption("Xdoclint:none", "-quiet")
+                    // Silence!
                     quiet()
                 }
             }

diff --git a/convention-plugin/src/main/kotlin/org/metaborg/convention/MavenPublishConventionPlugin.kt b/convention-plugin/src/main/kotlin/org/metaborg/convention/MavenPublishConventionPlugin.kt
@@ -94,6 +94,7 @@ class MavenPublishConventionPlugin: Plugin<Project> {
                     // Configure publishing to GitHub Packages
                     maven {
                         name = GITHUB_PACKAGES_PUBLICATION_NAME
+                        // NOTE: If repoOwner or repoName are not specified, this will fail. In that case we can't configure GitHub Packages
                         url = with(extension.repoOwner, extension.repoName) { owner, name -> uri("https://maven.pkg.github.com/$owner/$name") }.get()
                         credentials {
                             username = project.findProperty("gpr.user") as String? ?: System.getenv("GITHUB_ACTOR")