Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes in Command-line SPT transform expectation evaluation. #132

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

AZWN
Copy link
Contributor

@AZWN AZWN commented Jan 29, 2024

This PR fixes the following issues:

  • Bugs in SPT transformation expectation evaluation:
    • Pass proper Context(File) parameter
    • Pass proper Context(Project) parameter
    • Use regular selections, which correspond to the offsets seen by the object language parser.
  • Spoofax CLIs now give error codes when the underlying command fails. (no distinction between different errors is made (yet)).
  • CLI commands that execute test now print the total number of passed/failed test cases.
  • Some classes that are used in serialized configuration now implement Serializable, preventing errors.
  • In code completion, delayed queries are removed from the active constraint set, fixing non-termination issues.

The non-trivial changes are documented with inline comments.

@AZWN AZWN changed the title Some bugfixes Bugfixes in Command-line SPT transform expectation evaluation. Jan 29, 2024
@AZWN
Copy link
Contributor Author

AZWN commented Jan 29, 2024

Fixes #130

@AZWN AZWN requested a review from Apanatshka January 29, 2024 13:46
@Apanatshka
Copy link
Contributor

Please update the CHANGELOG.md with your changes, then feel free to merge.

@AZWN AZWN merged commit f0d6bd1 into develop Feb 9, 2024
@AZWN AZWN deleted the aml-release branch February 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants